Repository navigation
fix: wait out a quarantined ScreenCaptureKit gate and explain the refusal - #63
Merged
Merged
Conversation
iamnbutler
force-pushed
the
fix/sck-quarantine
branch
from
October 17, 2026 03:48
7ca486a to
6e02929
Compare
…usal (#16) A capture now waits up to 2 s for an abandoned ScreenCaptureKit call to return before refusing, and the refusal says the quarantine is temporary and asks the caller to retry. The private window lookup gets 3 s instead of 1 s, and the application inventory 2.5 s instead of 1 s. There is no fallback around a quarantine: every remaining capture path also uses ScreenCaptureKit.
iamnbutler
force-pushed
the
fix/sck-quarantine
branch
from
October 17, 2026 03:56
6e02929 to
b84c11d
Compare
This was referenced Oct 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #16.
What changes (new
peekaboo-sck-quarantine.patch, last in the stack):SCShareableContent.fetchWindowForWindowIDlookup or/usr/sbin/screencapture -l.screencaptureitself uses ScreenCaptureKit, andCGWindowListCreateImageis obsoleted. Any fallback would therefore start ScreenCaptureKit beside the abandoned call, which upstream rules out ("Private SCK fallback never crosses an abandoned operation"). The patch README has a paragraph saying so, so nobody adds a fallback later.apps3.5 s instead of 2.5 s, to fit the new budget.$TMPDIR. Keying it to the host app would let separate apps overlap ScreenCaptureKit calls again, which is what it prevents.Time per call: the worst case for a window capture is the 2 s grace period, plus the 3 s lookup timeout, plus a 2 s grace period on the next ScreenCaptureKit call before it refuses: about 7 s. That's within inspect's 20 s observation budget, the client's 25 s bridge request timeout and the 30 s MCP timeout, so none of those needed raising.
Tests (foreground, process-group wrapper, temporary coordination root):
ScreenCaptureKitQuarantineGraceTests(3 tests). Together withScreenCaptureKitOperationCoordinatorTestsandScreenCaptureKitTimeoutRaceTests, 11 tests pass.ApplicationInventoryTimeoutTests: 25 pass. One test advanced its fake clock by a fixed 2 s; it now advances past the default budget.npm run checkand the native build pass.Live check: pending (screen locked).